nybble
/
system76-dkms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce logging by identifying debug log messages correctly

This commit is contained in:
Jeremy Soller 2018-10-15 09:23:54 -06:00
parent 93caafa56a
commit ffd9bc6702
3 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
system76.c
View File

@ -103,13 +103,13 @@ static void s76_wmi_notify(u32 value, void *context) {
u32 event; u32 event;
if (value != 0xD0) { if (value != 0xD0) {
S76_INFO("Unexpected WMI event (%0#6x)\n", value); S76_DEBUG("Unexpected WMI event (%0#6x)\n", value);
return; return;
} }
s76_wmbb(GET_EVENT, 0, &event); s76_wmbb(GET_EVENT, 0, &event);
S76_INFO("WMI event code (%x)\n", event); S76_DEBUG("WMI event code (%x)\n", event);
switch (event) { switch (event) {
case 0x81: case 0x81:
@ -140,7 +140,7 @@ static void s76_wmi_notify(u32 value, void *context) {
s76_input_touchpad_wmi(true); s76_input_touchpad_wmi(true);
break; break;
default: default:
S76_INFO("Unknown WMI event code (%x)\n", event); S76_DEBUG("Unknown WMI event code (%x)\n", event);
break; break;
} }
} }
@ -204,7 +204,7 @@ static int s76_remove(struct platform_device *dev) {
} }
static int s76_suspend(struct platform_device *dev, pm_message_t status) { static int s76_suspend(struct platform_device *dev, pm_message_t status) {
S76_INFO("s76_suspend\n"); S76_DEBUG("s76_suspend\n");
kb_led_suspend(); kb_led_suspend();
@ -212,7 +212,7 @@ static int s76_suspend(struct platform_device *dev, pm_message_t status) {
} }
static int s76_resume(struct platform_device *dev) { static int s76_resume(struct platform_device *dev) {
S76_INFO("s76_resume\n"); S76_DEBUG("s76_resume\n");
msleep(2000); msleep(2000);

14
system76_input.c
View File

@ -58,7 +58,7 @@ MODULE_PARM_DESC(poll_freq, "Set polling frequency");
static struct task_struct *s76_input_polling_task; static struct task_struct *s76_input_polling_task;
static void s76_input_key(unsigned int code) { static void s76_input_key(unsigned int code) {
S76_INFO("Send key %x\n", code); S76_DEBUG("Send key %x\n", code);
mutex_lock(&s76_input_report_mutex); mutex_lock(&s76_input_report_mutex);
@ -72,7 +72,7 @@ static void s76_input_key(unsigned int code) {
} }
static int s76_input_polling_thread(void *data) { static int s76_input_polling_thread(void *data) {
S76_INFO("Polling thread started (PID: %i), polling at %i Hz\n", S76_DEBUG("Polling thread started (PID: %i), polling at %i Hz\n",
current->pid, param_poll_freq); current->pid, param_poll_freq);
while (!kthread_should_stop()) { while (!kthread_should_stop()) {
@ -82,7 +82,7 @@ static int s76_input_polling_thread(void *data) {
if (byte & 0x40) { if (byte & 0x40) {
ec_write(0xDB, byte & ~0x40); ec_write(0xDB, byte & ~0x40);
S76_INFO("Airplane-Mode Hotkey pressed (EC)\n"); S76_DEBUG("Airplane-Mode Hotkey pressed (EC)\n");
s76_input_key(AIRPLANE_KEY); s76_input_key(AIRPLANE_KEY);
} }
@ -90,16 +90,16 @@ static int s76_input_polling_thread(void *data) {
msleep_interruptible(1000 / param_poll_freq); msleep_interruptible(1000 / param_poll_freq);
} }
S76_INFO("Polling thread exiting\n"); S76_DEBUG("Polling thread exiting\n");
return 0; return 0;
} }
static void s76_input_airplane_wmi(void) { static void s76_input_airplane_wmi(void) {
S76_INFO("Airplane-Mode Hotkey pressed (WMI)\n"); S76_DEBUG("Airplane-Mode Hotkey pressed (WMI)\n");
if (s76_input_polling_task) { if (s76_input_polling_task) {
S76_INFO("Stopping polling thread\n"); S76_DEBUG("Stopping polling thread\n");
kthread_stop(s76_input_polling_task); kthread_stop(s76_input_polling_task);
s76_input_polling_task = NULL; s76_input_polling_task = NULL;
} }
@ -108,7 +108,7 @@ static void s76_input_airplane_wmi(void) {
} }
static void s76_input_touchpad_wmi(bool enabled) { static void s76_input_touchpad_wmi(bool enabled) {
S76_INFO("Touchpad Hotkey pressed (WMI) %d\n", enabled); S76_DEBUG("Touchpad Hotkey pressed (WMI) %d\n", enabled);
if (enabled) { if (enabled) {
s76_input_key(TOUCHPAD_ON_KEY); s76_input_key(TOUCHPAD_ON_KEY);

14
system76_kb-led.c
View File

@ -61,7 +61,7 @@ static enum led_brightness kb_led_get(struct led_classdev *led_cdev) {
} }
static int kb_led_set(struct led_classdev *led_cdev, enum led_brightness value) { static int kb_led_set(struct led_classdev *led_cdev, enum led_brightness value) {
S76_INFO("kb_led_set %d\n", (int)value); S76_DEBUG("kb_led_set %d\n", (int)value);
if (!s76_wmbb(SET_KB_LED, 0xF4000000 | value, NULL)) { if (!s76_wmbb(SET_KB_LED, 0xF4000000 | value, NULL)) {
kb_led_brightness = value; kb_led_brightness = value;
@ -73,7 +73,7 @@ static int kb_led_set(struct led_classdev *led_cdev, enum led_brightness value)
static void kb_led_color_set(enum kb_led_region region, union kb_led_color color) { static void kb_led_color_set(enum kb_led_region region, union kb_led_color color) {
u32 cmd; u32 cmd;
S76_INFO("kb_led_color_set %d %06X\n", (int)region, (int)color.rgb); S76_DEBUG("kb_led_color_set %d %06X\n", (int)region, (int)color.rgb);
switch (region) { switch (region) {
case KB_LED_REGION_LEFT: case KB_LED_REGION_LEFT:
@ -198,19 +198,19 @@ static struct device_attribute kb_led_color_extra_dev_attr = {
}; };
static void kb_led_enable(void) { static void kb_led_enable(void) {
S76_INFO("kb_led_enable\n"); S76_DEBUG("kb_led_enable\n");
s76_wmbb(SET_KB_LED, 0xE007F001, NULL); s76_wmbb(SET_KB_LED, 0xE007F001, NULL);
} }
static void kb_led_disable(void) { static void kb_led_disable(void) {
S76_INFO("kb_led_disable\n"); S76_DEBUG("kb_led_disable\n");
s76_wmbb(SET_KB_LED, 0xE0003001, NULL); s76_wmbb(SET_KB_LED, 0xE0003001, NULL);
} }
static void kb_led_suspend(void) { static void kb_led_suspend(void) {
S76_INFO("kb_led_suspend\n"); S76_DEBUG("kb_led_suspend\n");
// Disable keyboard backlight // Disable keyboard backlight
kb_led_disable(); kb_led_disable();
@ -219,7 +219,7 @@ static void kb_led_suspend(void) {
static void kb_led_resume(void) { static void kb_led_resume(void) {
enum kb_led_region region; enum kb_led_region region;
S76_INFO("kb_led_resume\n"); S76_DEBUG("kb_led_resume\n");
// Disable keyboard backlight // Disable keyboard backlight
kb_led_disable(); kb_led_disable();
@ -277,7 +277,7 @@ static void __exit kb_led_exit(void) {
} }
static void kb_wmi_brightness(enum led_brightness value) { static void kb_wmi_brightness(enum led_brightness value) {
S76_INFO("kb_wmi_brightness %d\n", (int)value); S76_DEBUG("kb_wmi_brightness %d\n", (int)value);
kb_led_set(&kb_led, value); kb_led_set(&kb_led, value);
led_classdev_notify_brightness_hw_changed(&kb_led, value); led_classdev_notify_brightness_hw_changed(&kb_led, value);