replace getNextPlayer with the pure function nextPlayerID

src/Waterdeep/Actions.hs

@@ -152,7 +152,7 @@ distributeQuests = do
          activePlayerState . playerIncompleteQuests <>= [quest]
          name <- use $ activePlayerName
          broadcast $ printf "%s chose the %s quest." name (quest ^. questTitle)
-         p' <- getNextPlayer =<< use gameActivePlayer
+         p' <- nextPlayerID <$> use gameActivePlayer <*> get
          withActivePlayer p' $ distribute (deleteAt i remQuests)
    distribute =<< catMaybes <$> (flip replicateM drawQuest' =<< use gameNumberOfPlayers)
 

src/Waterdeep/Logic.hs

@@ -105,17 +105,22 @@ waterdeepGame = do
                   , ("No",  return ())
                   ]
                gameConsecutivePasses .= 0
-               gameCurrentPlayer <~ (getNextPlayer =<< use gameCurrentPlayer)
+               advanceToNextPlayer
                loop
             Nothing -> do
                passes <- gameConsecutivePasses <+= 1
                when (passes < np) $ do
-                  gameCurrentPlayer <~ (getNextPlayer =<< use gameCurrentPlayer)
+                  advanceToNextPlayer
                   loop
    scoreFinalPoints
    notifyState
    determineWinners
 
+advanceToNextPlayer :: Waterdeep ()
+advanceToNextPlayer = do
+   p' <- nextPlayerID <$> use gameCurrentPlayer <*> get
+   gameCurrentPlayer .= p'
+
 beginRound :: Int -> Waterdeep ()
 beginRound round = do
    broadcast $ "Starting round " ++ show round ++ "."

src/Waterdeep/Types.hs

@@ -86,8 +86,8 @@ module Waterdeep.Types
    , activePlayerState
    , activePlayerName
    , withActivePlayer
+   , nextPlayerID
    , noPlayerID
-   , getNextPlayer
    , newPlayerState
    , newBuildingState
    , notifyState
@@ -325,10 +325,8 @@ withActivePlayer p m = do
    gameActivePlayer .= p0
    return r
 
-getNextPlayer :: PlayerID -> Waterdeep PlayerID
+nextPlayerID :: PlayerID -> WaterdeepState -> PlayerID
-getNextPlayer p = do
+nextPlayerID p w = (p `mod` (w ^. gameNumberOfPlayers)) + 1
-   np <- use gameNumberOfPlayers
-   return $ (p `mod` np) + 1
 
 noPlayerID :: PlayerID
 noPlayerID = 0